<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Cache: Deduplicate body data"
href="https://bugs.webkit.org/show_bug.cgi?id=143652#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Cache: Deduplicate body data"
href="https://bugs.webkit.org/show_bug.cgi?id=143652">bug 143652</a>
from <span class="vcard"><a class="email" href="mailto:koivisto@iki.fi" title="Antti Koivisto <koivisto@iki.fi>"> <span class="fn">Antti Koivisto</span></a>
</span></b>
<pre><span class="quote">> > Source/WebKit2/NetworkProcess/cache/NetworkCacheBlobStorage.cpp:60
> > + unlink(filePath.data());
>
> Why aren't we using WebCore::deleteFile()?</span >
I don't use the abstractions in this file because
- Existing abstractions don't cover everything needed and I don't want to expand them for no practical benefit. For consistency I use system calls everywhere.
- No one seems to be interested in making non-Posix port.
- Here specifically I want to to unlink, not delete anything. deleteFile might do wrong thing on non-Posix platform.
<span class="quote">> Why are we copying the Digest? (it is an std::array<uint8_t, 20>).</span >
It is still cheap and it reads better. Compiler may optimize moves.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>