[Webkit-unassigned] [Bug 143056] Use std::unique_ptr instead of PassOwnPtr|OwnPtr for ResourceResponse

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143056

--- Comment #7 from Joonghun Park <jh718.park at samsung.com> ---
(In reply to comment #6)
> Comment on attachment 249460 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249460&action=review
> 
> > Source/WebCore/loader/WorkerThreadableLoader.cpp:93
> > +    CrossThreadResourceRequestData* requestData = request.copyData().release();
> 
> Why do you change auto with CrossThreadResourceRequestData* ?
> 
I thought that it's not a type of std::unique_ptr but raw pointer, so I changed it back to raw pointer type. Do you think it would be better to use auto* here?
> > Source/WebCore/loader/WorkerThreadableLoader.cpp:163
> > +    CrossThreadResourceResponseData* responseData = response.copyData().release();
> 
> *auto* instead of CrossThreadResourceResponseData* ?
Same question here as I wrote above. How do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150412/06bf84f6/attachment-0001.html>