<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use std::unique_ptr instead of PassOwnPtr|OwnPtr for ResourceResponse"
href="https://bugs.webkit.org/show_bug.cgi?id=143056#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use std::unique_ptr instead of PassOwnPtr|OwnPtr for ResourceResponse"
href="https://bugs.webkit.org/show_bug.cgi?id=143056">bug 143056</a>
from <span class="vcard"><a class="email" href="mailto:jh718.park@samsung.com" title="Joonghun Park <jh718.park@samsung.com>"> <span class="fn">Joonghun Park</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143056#c6">comment #6</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=249460&action=diff" name="attach_249460" title="Patch">attachment 249460</a> <a href="attachment.cgi?id=249460&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=249460&action=review">https://bugs.webkit.org/attachment.cgi?id=249460&action=review</a>
>
> > Source/WebCore/loader/WorkerThreadableLoader.cpp:93
> > + CrossThreadResourceRequestData* requestData = request.copyData().release();
>
> Why do you change auto with CrossThreadResourceRequestData* ?
> </span >
I thought that it's not a type of std::unique_ptr but raw pointer, so I changed it back to raw pointer type. Do you think it would be better to use auto* here?
<span class="quote">> > Source/WebCore/loader/WorkerThreadableLoader.cpp:163
> > + CrossThreadResourceResponseData* responseData = response.copyData().release();
>
> *auto* instead of CrossThreadResourceResponseData* ?</span >
Same question here as I wrote above. How do you think?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>