[Webkit-unassigned] [Bug 138134] [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 9 01:58:28 PDT 2015


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #240789|commit-queue?               |commit-queue-
              Flags|                            |

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 240789
  --> https://bugs.webkit.org/attachment.cgi?id=240789
proposed wk patch ][

View in context: https://bugs.webkit.org/attachment.cgi?id=240789&action=review

I'm fine with the general idea. Martin, could you confirm you also agree with this patch?

> Source/WebKit2/ChangeLog:7
> +

Please, explain here why we need this.

> Tools/gtk/generate-inspector-gresource-manifest.py:31
> +        names = glob.glob(pattern)

patterns are not just names, but paths, so I would use paths or filenames instead.

> Tools/gtk/generate-inspector-gresource-manifest.py:33
> +            base_dir_index = filename.rfind(BASE_DIR)

BASE_DIR contains a /, isn't that a problem when os.sep is not /?

> Tools/gtk/generate-inspector-gresource-manifest.py:37
> +                if os.sep != '/':
> +                    name = name.replace(os.sep, '/')

I would add a comment here explaining that glob.glob changes the separator to the os one, but we need the paths with / in the xml file

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150409/e4898e79/attachment.html>

More information about the webkit-unassigned mailing list