<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py"
href="https://bugs.webkit.org/show_bug.cgi?id=138134">bug 138134</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #240789 Flags</td>
<td>commit-queue?
</td>
<td>commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py"
href="https://bugs.webkit.org/show_bug.cgi?id=138134#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py"
href="https://bugs.webkit.org/show_bug.cgi?id=138134">bug 138134</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=240789&action=diff" name="attach_240789" title="proposed wk patch ][">attachment 240789</a> <a href="attachment.cgi?id=240789&action=edit" title="proposed wk patch ][">[details]</a></span>
proposed wk patch ][
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=240789&action=review">https://bugs.webkit.org/attachment.cgi?id=240789&action=review</a>
I'm fine with the general idea. Martin, could you confirm you also agree with this patch?
<span class="quote">> Source/WebKit2/ChangeLog:7
> +</span >
Please, explain here why we need this.
<span class="quote">> Tools/gtk/generate-inspector-gresource-manifest.py:31
> + names = glob.glob(pattern)</span >
patterns are not just names, but paths, so I would use paths or filenames instead.
<span class="quote">> Tools/gtk/generate-inspector-gresource-manifest.py:33
> + base_dir_index = filename.rfind(BASE_DIR)</span >
BASE_DIR contains a /, isn't that a problem when os.sep is not /?
<span class="quote">> Tools/gtk/generate-inspector-gresource-manifest.py:37
> + if os.sep != '/':
> + name = name.replace(os.sep, '/')</span >
I would add a comment here explaining that glob.glob changes the separator to the os one, but we need the paths with / in the xml file</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>