[Webkit-unassigned] [Bug 143539] Web Inspector: Regression: Showing of color swatches no longer works in Details Sidebar

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143539

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250393|review?                     |review+, commit-queue+
              Flags|                            |

--- Comment #5 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 250393
  --> https://bugs.webkit.org/attachment.cgi?id=250393
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250393&action=review

>>> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:396
>>> +                this._codeMirror.setUniqueBookmark(codeMirrorTextMarker.find().from, swatchElement);
>> 
>> I think codeMirrorTextMarker.find() can return null/undefined. Maybe this need a null check and early return?
> 
> Nit: If that's the case I would rather create a new bug because I just re-enabled the code that was here before I removed it. Just without the variable declaration that initially triggered the ESLint report. I can investigate into the missing null check afterwards, if that's okay for you?

Fair enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150409/e6ae6fbb/attachment.html>