<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Regression: Showing of color swatches no longer works in Details Sidebar"
href="https://bugs.webkit.org/show_bug.cgi?id=143539">bug 143539</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #250393 Flags</td>
<td>review?
</td>
<td>review+, commit-queue+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Regression: Showing of color swatches no longer works in Details Sidebar"
href="https://bugs.webkit.org/show_bug.cgi?id=143539#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Regression: Showing of color swatches no longer works in Details Sidebar"
href="https://bugs.webkit.org/show_bug.cgi?id=143539">bug 143539</a>
from <span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250393&action=diff" name="attach_250393" title="patch">attachment 250393</a> <a href="attachment.cgi?id=250393&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250393&action=review">https://bugs.webkit.org/attachment.cgi?id=250393&action=review</a>
<span class="quote">>>> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:396
>>> + this._codeMirror.setUniqueBookmark(codeMirrorTextMarker.find().from, swatchElement);
>>
>> I think codeMirrorTextMarker.find() can return null/undefined. Maybe this need a null check and early return?
>
> Nit: If that's the case I would rather create a new bug because I just re-enabled the code that was here before I removed it. Just without the variable declaration that initially triggered the ESLint report. I can investigate into the missing null check afterwards, if that's okay for you?</span >
Fair enough.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>