[Webkit-unassigned] [Bug 143047] REGRESSION(r181844): [GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session fails after r181844

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143047

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > So we fixed an early runtime error in the frontend soon after that:
> > > http://trac.webkit.org/changeset/181905
> > > 
> > > Can you see if this test still fails after that revision?
> > 
> > Yes, remote inspector is still broken. I see a lot of js errors in the
> > console, like:
> 
> It sounds like you're running into an early error. For instance:
> 
> > TypeError: undefined is not an object (evaluating 'this.modifierKeys.altKey')
> 
> This sounds like:
> 
>     WebInspector._updateModifierKeys = function(event)
>     {
>         var didChange = this.modifierKeys.altKey !== event.altKey ||
> this.modifierKeys.metaKey !== event.metaKey || this.modifierKeys.shiftKey
> !== event.shiftKey;
>         ...
>     };
> 
> Somehow this code got called and either "this" or "this.modifierKeys" was
> undefined. That shouldn't happen, modifierKeys is initialized in
> WebInspector.contentLoaded.

It's this.modifierKeys, I managed to fix this particular issue by moving the initialization of this.modifierKeys earlier in WebInspector.contentLoaded.

> 
> 
> > TypeError: undefined is not an object (evaluating
> > 'WebInspector.Resizer.RuleOrientation.Vertical')
> 
> This should be defined via Resizer.js.

Yes, tried something similar but it didn't work.

> 
> > It seems to me that the remote inspector is trying to load the non-remote ui
> > or something like that.
> 
> - Are there earlier errors? The earliest error may give an indication as
> what is going on!

I think those were the first ones, but I'll try again.

> - Are ES6 classes supported in the browser showing the remote inspector?

I used the MiniBrowser for both.

> - Maybe Symbol is not supported? Timothy Hatcher has a patch that
> monkey-patches that in to a degree:
> Adding a window.Symbol to InspectorFrontendHostStub.js
> 
> I suspect it is window.Symbol issues.

I'll try, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150408/b1ef3c5e/attachment-0001.html>