<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r181844): [GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session fails after r181844"
href="https://bugs.webkit.org/show_bug.cgi?id=143047#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r181844): [GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session fails after r181844"
href="https://bugs.webkit.org/show_bug.cgi?id=143047">bug 143047</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143047#c3">comment #3</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=143047#c2">comment #2</a>)
> > (In reply to <a href="show_bug.cgi?id=143047#c1">comment #1</a>)
> > > So we fixed an early runtime error in the frontend soon after that:
> > > <a href="http://trac.webkit.org/changeset/181905">http://trac.webkit.org/changeset/181905</a>
> > >
> > > Can you see if this test still fails after that revision?
> >
> > Yes, remote inspector is still broken. I see a lot of js errors in the
> > console, like:
>
> It sounds like you're running into an early error. For instance:
>
> > TypeError: undefined is not an object (evaluating 'this.modifierKeys.altKey')
>
> This sounds like:
>
> WebInspector._updateModifierKeys = function(event)
> {
> var didChange = this.modifierKeys.altKey !== event.altKey ||
> this.modifierKeys.metaKey !== event.metaKey || this.modifierKeys.shiftKey
> !== event.shiftKey;
> ...
> };
>
> Somehow this code got called and either "this" or "this.modifierKeys" was
> undefined. That shouldn't happen, modifierKeys is initialized in
> WebInspector.contentLoaded.</span >
It's this.modifierKeys, I managed to fix this particular issue by moving the initialization of this.modifierKeys earlier in WebInspector.contentLoaded.
<span class="quote">>
>
> > TypeError: undefined is not an object (evaluating
> > 'WebInspector.Resizer.RuleOrientation.Vertical')
>
> This should be defined via Resizer.js.</span >
Yes, tried something similar but it didn't work.
<span class="quote">>
> > It seems to me that the remote inspector is trying to load the non-remote ui
> > or something like that.
>
> - Are there earlier errors? The earliest error may give an indication as
> what is going on!</span >
I think those were the first ones, but I'll try again.
<span class="quote">> - Are ES6 classes supported in the browser showing the remote inspector?</span >
I used the MiniBrowser for both.
<span class="quote">> - Maybe Symbol is not supported? Timothy Hatcher has a patch that
> monkey-patches that in to a degree:
> Adding a window.Symbol to InspectorFrontendHostStub.js
>
> I suspect it is window.Symbol issues.</span >
I'll try, thanks.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>