[Webkit-unassigned] [Bug 143255] WebRTC: Add support for Promise-based MediaDevices.getUserMedia()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 2 07:20:58 PDT 2015


--- Comment #3 from Adam Bergkvist <adam.bergkvist at ericsson.com> ---
(In reply to comment #2)
> Nit: I think this would be slightly easier to read and understand if it was
> indented.

I found a few different styles among the tests, but most tests within the mediastream module seems to be indented so I'll align this test.

> > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:204
> >      RefPtr<NavigatorUserMediaError> error = NavigatorUserMediaError::create(NavigatorUserMediaError::permissionDeniedErrorName(), emptyString());
> Shouldn't this be a MediaStreamError? If so, please add a FIXME: with a bug.

I'll do that.

Thanks for reviewing.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150402/ef14a5a2/attachment.html>

More information about the webkit-unassigned mailing list