[Webkit-unassigned] [Bug 143248] [CSS MultiColumn] Parse "columns: auto <length>" shorthand property value properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143248

--- Comment #22 from Joonghun Park <jh718.park at samsung.com> ---
(In reply to comment #21)
> Comment on attachment 249890 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249890&action=review
> 
> >> Source/WebCore/css/CSSParser.cpp:3661
> >> +    ASSERT(columnCount || coulmnWidth);
> > 
> > This will fail to compile because of the typo: coulmnWidth.
> 
> I missed this one. Why do you remove this ASSERT ?
> 
> Don't you need to add below ?
> 
> ASSERT(columnCount || columnWidth);

As you can see in https://bugs.webkit.org/attachment.cgi?id=249815&action=review,
this patch originally included 'if (hasPendingExplicitAuto) clause' in CSSParser.cpp:3661.
But Darin pointed out that this is not necessary and can be more simplified, and told me how to do that. So I removed the assert statement applying darin's feedback. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150402/bcd9a3c0/attachment-0001.html>