<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [CSS MultiColumn] Parse "columns: auto <length>" shorthand property value properly"
href="https://bugs.webkit.org/show_bug.cgi?id=143248#c22">Comment # 22</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [CSS MultiColumn] Parse "columns: auto <length>" shorthand property value properly"
href="https://bugs.webkit.org/show_bug.cgi?id=143248">bug 143248</a>
from <span class="vcard"><a class="email" href="mailto:jh718.park@samsung.com" title="Joonghun Park <jh718.park@samsung.com>"> <span class="fn">Joonghun Park</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143248#c21">comment #21</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=249890&action=diff" name="attach_249890" title="Patch">attachment 249890</a> <a href="attachment.cgi?id=249890&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=249890&action=review">https://bugs.webkit.org/attachment.cgi?id=249890&action=review</a>
>
> >> Source/WebCore/css/CSSParser.cpp:3661
> >> + ASSERT(columnCount || coulmnWidth);
> >
> > This will fail to compile because of the typo: coulmnWidth.
>
> I missed this one. Why do you remove this ASSERT ?
>
> Don't you need to add below ?
>
> ASSERT(columnCount || columnWidth);</span >
As you can see in <a href="https://bugs.webkit.org/attachment.cgi?id=249815&action=review">https://bugs.webkit.org/attachment.cgi?id=249815&action=review</a>,
this patch originally included 'if (hasPendingExplicitAuto) clause' in CSSParser.cpp:3661.
But Darin pointed out that this is not necessary and can be more simplified, and told me how to do that. So I removed the assert statement applying darin's feedback. :)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>