[Webkit-unassigned] [Bug 138562] [GStreamer] GstGL support in the video sink

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138562

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249729|review?                     |review+
              Flags|                            |

--- Comment #39 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 249729
  --> https://bugs.webkit.org/attachment.cgi?id=249729
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249729&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:363
> +            // Rendering should be done from the main thread
> +            // because this is where the GL APIs were initialized.
> +            ASSERT(isMainThread());

I think the important thing here is not that the lambda runs in the main thread, we are scheduling this in the default main context so it will be in the main thread. What matter is that MediaPlayerPrivateGStreamerBase::triggerRepaint is not called in the main thread, because it's going to be blocked waiting for the task to complete. So, I would remove this assert and add ASSERT(!isMainThread()); at the beginning of MediaPlayerPrivateGStreamerBase::triggerRepaint.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:425
> +        RefPtr<BitmapTexture> texture = updateTexture(textureMapper);
> +        if (texture)

This could be if (RefPtr<BitmapTexture> texture = updateTexture(textureMapper)) I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150401/47a21fad/attachment.html>