<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] GstGL support in the video sink"
href="https://bugs.webkit.org/show_bug.cgi?id=138562">bug 138562</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #249729 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] GstGL support in the video sink"
href="https://bugs.webkit.org/show_bug.cgi?id=138562#c39">Comment # 39</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] GstGL support in the video sink"
href="https://bugs.webkit.org/show_bug.cgi?id=138562">bug 138562</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=249729&action=diff" name="attach_249729" title="patch">attachment 249729</a> <a href="attachment.cgi?id=249729&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=249729&action=review">https://bugs.webkit.org/attachment.cgi?id=249729&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:363
> + // Rendering should be done from the main thread
> + // because this is where the GL APIs were initialized.
> + ASSERT(isMainThread());</span >
I think the important thing here is not that the lambda runs in the main thread, we are scheduling this in the default main context so it will be in the main thread. What matter is that MediaPlayerPrivateGStreamerBase::triggerRepaint is not called in the main thread, because it's going to be blocked waiting for the task to complete. So, I would remove this assert and add ASSERT(!isMainThread()); at the beginning of MediaPlayerPrivateGStreamerBase::triggerRepaint.
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:425
> + RefPtr<BitmapTexture> texture = updateTexture(textureMapper);
> + if (texture)</span >
This could be if (RefPtr<BitmapTexture> texture = updateTexture(textureMapper)) I think.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>