[Webkit-unassigned] [Bug 137193] [GTK] Move GtkPopupMenu implementation to WebPopupMenuProxyGtk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 30 05:50:39 PDT 2014


--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-09-30 05:50:34 PST ---
(In reply to comment #3)
> (From update of attachment 238812 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238812&action=review
> LGTM with one question:
> > Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:-69
> > -        m_popup->clear();
> Is clearing the menu no longer necessary? I couldn't figure out what change makes this not needed.

Yes, I'm not sure if that was there because WebKit1 worked differently, but in WebKit2, the same WebPopupMenuProxy can't be populated twice, the page proxy always creates a new WebPopupMenuProxy when it receives the ShowPopupMenu message and if there was an active one already, it's destroyed.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list