[Webkit-unassigned] [Bug 137193] [GTK] Move GtkPopupMenu implementation to WebPopupMenuProxyGtk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 30 05:44:10 PDT 2014


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
 Attachment #238812|review?                     |review+
               Flag|                            |

--- Comment #3 from Gustavo Noronha (kov) <gns at gnome.org>  2014-09-30 05:44:06 PST ---
(From update of attachment 238812)
View in context: https://bugs.webkit.org/attachment.cgi?id=238812&action=review

LGTM with one question:

> Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:-69
> -        m_popup->clear();

Is clearing the menu no longer necessary? I couldn't figure out what change makes this not needed.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list