[Webkit-unassigned] [Bug 21562] Layering violation: MediaPlayer should not reference/use FrameView

Thu Sep 25 11:24:39 PDT 2014

https://bugs.webkit.org/show_bug.cgi?id=21562

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-09-25 11:24:39 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> >  - MediaPlayerPrivateQTKit also uses it to get the ColorSpace and Font in order to render the frame rate. I wonder if we could pass those somehow from RenderVideo, or add a MediaPlayer::paintFrameRate(ColorSpace, Font) called after paint() by RenderVideo, and implemented only by MediaPlayerPrivateQTKit. Another approach would be to add media player methods to get the colorspace and font, implemented by the HTMLMediaElement.
> 
> Don't worry about that, the frame rate code is not compiled by default and should be deleted in any case. I will remove it when I get some spare time.

Oh, much better :-)

> >  - And finally it's used again by MediaPlayerPrivateQTKit to make the QTMovieView a subview of the document view. I have no idea what this means.
> 
> This code can be removed as well, although it is compiled by default. Why don't you file a bug about removing it and block this bug on it. I will find some time to take care of it in the next couple of days.

Sure, thanks for your help.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.