[Webkit-unassigned] [Bug 21562] Layering violation: MediaPlayer should not reference/use FrameView

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 25 10:33:39 PDT 2014


--- Comment #3 from Eric Carlson <eric.carlson at apple.com>  2014-09-25 10:33:38 PST ---
(In reply to comment #2)
>  - MediaPlayerPrivateQTKit also uses it to get the ColorSpace and Font in order to render the frame rate. I wonder if we could pass those somehow from RenderVideo, or add a MediaPlayer::paintFrameRate(ColorSpace, Font) called after paint() by RenderVideo, and implemented only by MediaPlayerPrivateQTKit. Another approach would be to add media player methods to get the colorspace and font, implemented by the HTMLMediaElement.

Don't worry about that, the frame rate code is not compiled by default and should be deleted in any case. I will remove it when I get some spare time.

>  - And finally it's used again by MediaPlayerPrivateQTKit to make the QTMovieView a subview of the document view. I have no idea what this means.

This code can be removed as well, although it is compiled by default. Why don't you file a bug about removing it and block this bug on it. I will find some time to take care of it in the next couple of days.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list