[Webkit-unassigned] [Bug 63290] Stack overflow with enormous SVG filter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63290





--- Comment #21 from Said Abou-Hallawa <sabouhallawa at apple.com>  2014-09-25 09:58:42 PST ---
(In reply to comment #20)
> (From update of attachment 238630 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238630&action=review
> 
> Looks good. Just some smaller snippets.
> 
> > Source/WebCore/platform/graphics/filters/FilterEffect.cpp:113
> > +        depth = std::max(depth, in->depthOfEffectInputs());
> 
> Just a little misunderstanding I suppose. Not the depth matters, but the amount of effects matters. So just sum up all effects.
I am not sure I understand your point here.  Summing up all the effects will get us the total number of effects in the filter tree.  But we already have a cut off condition on the total number of effects in the filter map to be < 200.  Why do we need to limit the number of the used effects by the filter to be < 100?  I thought we care about the depth because it represents how much complex the filter composition will be.  But the total number of effects used by the filter does not reveal this information.
> 
> > Source/WebCore/rendering/svg/RenderSVGResourceFilter.h:90
> > +    const unsigned s_maxCountOfInputEffects = 200; // maximum number of input effects regardless whether they are connected to a filter's lastEffect or not
> 
> Please use sentences as comments with periods. Move the comment a line up before the constant. Also, can't it be static constant? You already use s_.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.