[Webkit-unassigned] [Bug 63290] Stack overflow with enormous SVG filter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63290


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238630|review?                     |review-
               Flag|                            |




--- Comment #20 from Dirk Schulze <krit at webkit.org>  2014-09-25 00:00:10 PST ---
(From update of attachment 238630)
View in context: https://bugs.webkit.org/attachment.cgi?id=238630&action=review

Looks good. Just some smaller snippets.

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:113
> +        depth = std::max(depth, in->depthOfEffectInputs());

Just a little misunderstanding I suppose. Not the depth matters, but the amount of effects matters. So just sum up all effects.

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.h:90
> +    const unsigned s_maxCountOfInputEffects = 200; // maximum number of input effects regardless whether they are connected to a filter's lastEffect or not

Please use sentences as comments with periods. Move the comment a line up before the constant. Also, can't it be static constant? You already use s_.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.