[Webkit-unassigned] [Bug 136150] [ATK] Changing the mapping of aria rowheader and columnheader into respective ATK roles.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136150





--- Comment #14 from Andrzej Badowski <a.badowski at samsung.com>  2014-09-08 03:59:50 PST ---
(From update of attachment 237694)
View in context: https://bugs.webkit.org/attachment.cgi?id=237694&action=review

Thank you for your review.

>> LayoutTests/accessibility/roles-exposed.html:210
>> +            <!-- [ATK] Wrong role (webkit.org/b/125493) --><div data-platform="atk,mac" role="columnheader" class="ex">X</div>
> 
> Please remove the prefixed comments (and post a comment in bug 125493 too, if possible)

OK

>> LayoutTests/accessibility/roles-exposed.html:274
>> +            <!-- [ATK] Wrong role (webkit.org/b/125493) --><div role="columnheader" data-platform="atk,mac" class="ex">X</div>
> 
> Ditto

OK

>> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2564
>> +        for ( ; node; node = node->parentNode()) {
> 
> I think a 'while (node)' statement would be better in this case

I agree.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.