[Webkit-unassigned] [Bug 136150] [ATK] Changing the mapping of aria rowheader and columnheader into respective ATK roles.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136150





--- Comment #13 from Mario Sanchez Prada <mario at webkit.org>  2014-09-08 02:09:02 PST ---
(From update of attachment 237694)
View in context: https://bugs.webkit.org/attachment.cgi?id=237694&action=review

> LayoutTests/accessibility/roles-exposed.html:210
> +            <!-- [ATK] Wrong role (webkit.org/b/125493) --><div data-platform="atk,mac" role="rowheader"    class="ex">X</div>
> +            <!-- [ATK] Wrong role (webkit.org/b/125493) --><div data-platform="atk,mac" role="columnheader" class="ex">X</div>

Please remove the prefixed comments (and post a comment in bug 125493 too, if possible)

> LayoutTests/accessibility/roles-exposed.html:274
> +            <!-- [ATK] Wrong role (webkit.org/b/125493) --><div role="rowheader"    data-platform="atk,mac" class="ex">X</div>
> +            <!-- [ATK] Wrong role (webkit.org/b/125493) --><div role="columnheader" data-platform="atk,mac" class="ex">X</div>

Ditto

> Source/WebCore/ChangeLog:10
> +        No new tests because the existing test with minor amendments and other tests cover it.
> +
> +        Proposals for changes in the code that allow using listed ARIA roles.

I know it's a proposal for discussion, but just in case, we normally put first the line describing the patch and last the one mentioning the tests (new or not) covering the changes. Would be nice to consider that for future patches

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2564
> +        for ( ; node; node = node->parentNode()) {

I think a 'while (node)' statement would be better in this case

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:684
> +    case RowHeaderRole:
> +        return ATK_ROLE_ROW_HEADER;
> +    case ColumnHeaderRole:
> +        return ATK_ROLE_COLUMN_HEADER;

I wonder if this change will break other a11y tests or functionality if that some AccessibilityObjects that used to report a CellRole role will now report a ColumnHeaderRole or RowHeaderRole. I have the feeling that some more changes would be needed such as, for instance, to update the roleIsTextType() static function in the ATK wrapper.

Also, it would be great if you could share here a plain text representation of the ATK hierarchy that would be exposed for some common cases of HTML tables with column/row headers, so we are sure that whatever we will be exposing is what ATs (e.g. Orca) do expect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.