[Webkit-unassigned] [Bug 136545] Serialize ResourceResponses using WebKit types

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 5 10:20:02 PDT 2014


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #237693|review?                     |review+
               Flag|                            |

--- Comment #4 from Alexey Proskuryakov <ap at webkit.org>  2014-09-05 10:20:04 PST ---
(From update of attachment 237693)
View in context: https://bugs.webkit.org/attachment.cgi?id=237693&action=review

Antti checked what CFNetwork serialization code does, and it seems like we don't lose much.

r=me with the comments addressed, and Gtk build fixed.

> Source/WebCore/platform/network/ResourceResponseBase.h:232
> +    if (!decoder.decode(response.m_httpStatusText))
> +        return false;

We need a Radar and a FIXME somewhere (not here) about how we fail to add m_httpStatusText to NSURLResponse when re-creating it.

This patch fixes status text for XHR, but breaks it for API clients.

The XHR issue this fixes is rdar://problem/13751647, please unskip the tests.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list