[Webkit-unassigned] [Bug 136545] Serialize ResourceResponses using WebKit types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136545





--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2014-09-05 09:49:15 PST ---
(From update of attachment 237693)
View in context: https://bugs.webkit.org/attachment.cgi?id=237693&action=review

> Source/WebCore/ChangeLog:3
> +        Serialize ResourceResponses using WebKit types

This seems like a good idea, but I honestly don't know how to evaluate correctness. Perhaps I'm too scarred from dealing with ResourceRequest, which is admittedly much more involved.

Did you check CFNetwork response serialization code for things that we don't extract into the WebCore class?

> Source/WebCore/platform/network/mac/ResourceResponseMac.mm:70
> -NSURLResponse *ResourceResponse::nsURLResponse() const
> +NSURLResponse* ResourceResponse::nsURLResponse() const

This star was positioned correctly.

> Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:-154
> -    RetainPtr<CFDictionaryRef> dictionary = adoptCF(WKNSURLResponseCreateSerializableRepresentation(resourceResponse.nsURLResponse(), IPC::tokenNullTypeRef()));

WKNSURLResponseCreateSerializableRepresentation should be removed from WKSI now. This patch could remove a declaration from the open source copy.

> Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:-173
> -    RetainPtr<NSURLResponse> nsURLResponse = WKNSURLResponseFromSerializableRepresentation(dictionary.get(), IPC::tokenNullTypeRef());

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.