[Webkit-unassigned] [Bug 136534] Remove ResourceResponse::m_suggestedFilename

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 4 10:46:41 PDT 2014


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #237630|review?                     |review+
               Flag|                            |

--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2014-09-04 10:46:46 PST ---
(From update of attachment 237630)
View in context: https://bugs.webkit.org/attachment.cgi?id=237630&action=review


> Source/WebCore/platform/network/mac/ResourceResponseMac.mm:62
> +    for (const auto& header : m_httpHeaderFields)

I think that "auto&" is all the rage these days, not "const auto&".

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:812
> +    auto* headers = [NSMutableDictionary dictionaryWithObjectsAndKeys:

I think that we can and should use @{} here, there seems to be no reason for the dictionary to be mutable.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list