[Webkit-unassigned] [Bug 138171] FormData should not use Document, Page, Chrome and ChromeClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138171

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
I've been looking at this in more detail, and it seems to me that the replacement file generations should happen automatically already. The BlobDataFileReference objects, already to the generation on demand when the path() or size() methods are used. The File object also computes the replaced name and content type in its constructor. I can't test this, because the file replacement thing is a mac only feature, but looking at the code I would say that:

 - In FormData::appendKeyValuePairItems, the name and content type we get form the File blob are already computed, so we wouldn't need to use the chrome client, that only computes the name but no the content type. 

  - We don't need to generate the files explicitly, when the Blob files are added to the actual HTTP body by the resource handle, the path() method of BlobDataFileReference will be called to read the file, ensuring the replacement files are generated.

  - And we don't need to explicitly delete the generated files, because the BlobDataFileReference destructor does it already.

I've also noticed that FormData uses FormDataList, that surprisingly it's not in platform but in html. We can probably just move FormDataList to platform, or is there any reason for it to be in html?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141030/fa4e99c6/attachment-0002.html>