[Webkit-unassigned] [Bug 138171] FormData should not use Document, Page, Chrome and ChromeClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138171

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 240599 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240599&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        FormData uses the ChromeClient to ask the WebKit layer whether to
> > +        replace upload files with generated files and to actually
> > +        generate the replacement files. We could use std::functions passed
> > +        to FormData instead of calling ChromeClient methods directly.
> 
> This is OK to do, although a better fix would be to stop using the chrome
> client, and use file replacement code from
> BlobDataFileReference::generateReplacementFile(). That would require some
> refactoring, but the code is already in WebCore/platform.

Ah, I didn't know BlobDataFileReference::generateReplacementFile(), I'll rework it then.

> Right now, we potentially archive a bundle twice, first via Blob code path
> if the file is ever accessed via File API, and then via the chrome client if
> the file end up being submitted via a form.
> 
> I did not review the patch in detail.

I'll try to refactor the code to use BlobDataFileReference instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141030/b3852744/attachment-0002.html>