[Webkit-unassigned] [Bug 138093] [GTK] Move RedirectedXCompositeWindow from platform to WebKit2 layer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138093

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 240480 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240480&action=review
> 
> > Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp:-189
> > -    if (m_needsContext == CreateGLContext) {
> > -        context()->waitNative();
> > -        // This swap is based on code in Chromium. It tries to work-around a bug in the Intel drivers
> > -        // where a swap is necessary to ensure the front and back buffers are properly resized.
> > -        if (context() == GLContext::getCurrent())
> > -            context()->swapBuffers();
> > -    }
> > -
> 
> I'm not sure that it is appropriate to remove this workaround in this patch.

That's dead code, since the CreateGLContext mode is not used at all.

> Please move the file and then make separate changes (like the cool anonymous
> function) in separate patches. I'm worried about introducing hidden
> regressions.

I can make a diff of the file.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:-75
> > -#if USE(TEXTURE_MAPPER_GL) && PLATFORM(X11)
> > -#include <WebCore/RedirectedXCompositeWindow.h>
> > -#endif
> 
> I think we need to maintain at least PLATFORM(X11) here to deal with Wayland.

It's done in the header already, we usually try to avoid #ifdefs around header includes, by adding the ifdefs in the headers, in this case, the header was already protected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141028/d3144bd4/attachment-0002.html>