[Webkit-unassigned] [Bug 138093] [GTK] Move RedirectedXCompositeWindow from platform to WebKit2 layer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138093

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240480|review?                     |review-
              Flags|                            |

--- Comment #3 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 240480
  --> https://bugs.webkit.org/attachment.cgi?id=240480
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240480&action=review

> Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp:-189
> -    if (m_needsContext == CreateGLContext) {
> -        context()->waitNative();
> -        // This swap is based on code in Chromium. It tries to work-around a bug in the Intel drivers
> -        // where a swap is necessary to ensure the front and back buffers are properly resized.
> -        if (context() == GLContext::getCurrent())
> -            context()->swapBuffers();
> -    }
> -

I'm not sure that it is appropriate to remove this workaround in this patch. Please move the file and then make separate changes (like the cool anonymous function) in separate patches. I'm worried about introducing hidden regressions.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:-75
> -#if USE(TEXTURE_MAPPER_GL) && PLATFORM(X11)
> -#include <WebCore/RedirectedXCompositeWindow.h>
> -#endif

I think we need to maintain at least PLATFORM(X11) here to deal with Wayland.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141027/8ff50bef/attachment-0002.html>