[Webkit-unassigned] [Bug 137772] ASSERTION FAILED: growthShare > 0 in WebCore::RenderGrid::distributeSpaceToTracks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 28 00:12:47 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=137772

--- Comment #4 from Sergio Villar Senin <svillar at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 240006 [details]
> > LayoutTests/fast/css-grid-layout/tracks-number-greatly-exceeding-available-size-crash.html:12
> > +	<div style="width: 1px; -webkit-grid-column-start: span 100;"></div>
> 
> Let's increase test coverage.
> -Let's add multiple test covering big numbers: 100, 1000, 10000, etc

There is no different code path for those big numbers, once the difference between width and the number of tracks exceeds 2 orders of magnitude then the result is 0. Anyway it won't hurt.

> -Let's cover width:0; and width:1px;

The case of width: 0px was not intentionally added because in that case the function with the ASSERT won't ever be called.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141028/30b2c05b/attachment-0002.html>


More information about the webkit-unassigned mailing list