[Webkit-unassigned] [Bug 137772] ASSERTION FAILED: growthShare > 0 in WebCore::RenderGrid::distributeSpaceToTracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137772

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240006|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #3 from Benjamin Poulain <benjamin at webkit.org> ---
Comment on attachment 240006
  --> https://bugs.webkit.org/attachment.cgi?id=240006
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240006&action=review

Looks reasonable :)

> Source/WebCore/rendering/RenderGrid.cpp:651
> +            // We should never shrink any grid track or else we can't guarantee we abide by our min-sizing function. We
> +            // can still have 0 as growthShare if the amount of tracks greatly exceeds the availableLogicalSpace.

The right way to do this kind of comment for an assertion is ASSERT_WITH_MESSAGE.

> LayoutTests/fast/css-grid-layout/tracks-number-greatly-exceeding-available-size-crash.html:12
> +	<div style="width: 1px; -webkit-grid-column-start: span 100;"></div>

Let's increase test coverage.
-Let's add multiple test covering big numbers: 100, 1000, 10000, etc
-Let's cover width:0; and width:1px;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141027/992d5b34/attachment-0002.html>