[Webkit-unassigned] [Bug 137930] Fullscreen video dismissal can put application to incorrect orientation on iOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137930

--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 240214
  --> https://bugs.webkit.org/attachment.cgi?id=240214
Fix Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240214&action=review

>>> Source/WebCore/ChangeLog:11
>>> +        the retained window for putting the device in correct orientation after dismissal.
>> 
>> Instead of retaining the UIWindow, could we just store the result of calling interfaceOrientation? Or is it helpful to call the interfaceOrientation method at the time of dismissal?
> 
> It is necessary that we get the interfaceOrientation at the time of dismissal, because after entering the fullscreen video, the user could start rotating the device and depending on window's view controller rotation handling code, possibly change the orientation of the window.

One alternative would be to use delegate notifications (e.g., - window:willRotateToInterfaceOrientation:duration:) that the window's orientation will change, and save the result.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141021/adfa9376/attachment-0002.html>