[Webkit-unassigned] [Bug 137930] Fullscreen video dismissal can put application to incorrect orientation on iOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137930

--- Comment #3 from rabbasian at apple.com ---
(In reply to comment #2)
> Comment on attachment 240214 [details]
> Fix Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240214&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        When a fullscreen video gets dismissed programmatically, for instance for removing
> > +        a webview from the view hierarchy, it can put the device in an incorrect orientation.
> > +        Make sure we retain the window of parentView when we attempt to go to fullscreen and use
> > +        the retained window for putting the device in correct orientation after dismissal.
> 
> Instead of retaining the UIWindow, could we just store the result of calling
> interfaceOrientation? Or is it helpful to call the interfaceOrientation
> method at the time of dismissal?

It is necessary that we get the interfaceOrientation at the time of dismissal, because after entering the fullscreen video, the user could start rotating the device and depending on window's view controller rotation handling code, possibly change the orientation of the window.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141021/adc5650f/attachment-0002.html>