[Webkit-unassigned] [Bug 137812] [GTK] Add initial gestures support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137812

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #5)
> Comment on attachment 240012 [details]
> Fix the build with GTK+ < 3.14
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240012&action=review

Thanks for the review.

> I wonder if this allows us to pass any new tests.

I haven't checked, will run touch tests.

>  Otherwise I'd have to
> trust you on the gtk touch specific code. Have you double-checked the
> implementation with Garnacho?

Yes.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:898
> > +#endif
> 
> We should change this name as we need to make explicit the fact that it
> might create the GestureController. What about
> webkitWebViewBaseGetOrCreateGestureController ?

Why does it have to be explicit? The caller doesn't need to know anything since it's receiving a reference.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h:79
> > +WebKit::GestureController& webkitWebViewBaseGestureController(WebKitWebViewBase*);
> 
> See above.
> 
> > Source/WebKit2/UIProcess/gtk/GestureController.cpp:44
> > +    return std::unique_ptr<GestureController>(new GestureController(page));
> 
> I think the preferred form is std::make_unique<GestureController>(page);

It doesn't build.

> > Source/WebKit2/UIProcess/gtk/GestureController.cpp:133
> > +    int delay;
> 
> Nit, uint

gtk-long-press-time is a guint.

> > Source/WebKit2/UIProcess/gtk/GestureController.cpp:137
> > +    }, std::chrono::milliseconds(delay));
> 
> We should convert this to microseconds after r174818

No, this is already in milliseconds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141017/dd78a1f6/attachment-0002.html>