[Webkit-unassigned] [Bug 137812] [GTK] Add initial gestures support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137812

--- Comment #5 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 240012
  --> https://bugs.webkit.org/attachment.cgi?id=240012
Fix the build with GTK+ < 3.14

View in context: https://bugs.webkit.org/attachment.cgi?id=240012&action=review

I wonder if this allows us to pass any new tests. Otherwise I'd have to trust you on the gtk touch specific code. Have you double-checked the implementation with Garnacho?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:898
> +#endif

We should change this name as we need to make explicit the fact that it might create the GestureController. What about webkitWebViewBaseGetOrCreateGestureController ?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h:79
> +WebKit::GestureController& webkitWebViewBaseGestureController(WebKitWebViewBase*);

See above.

> Source/WebKit2/UIProcess/gtk/GestureController.cpp:44
> +    return std::unique_ptr<GestureController>(new GestureController(page));

I think the preferred form is std::make_unique<GestureController>(page);

> Source/WebKit2/UIProcess/gtk/GestureController.cpp:133
> +    int delay;

Nit, uint

> Source/WebKit2/UIProcess/gtk/GestureController.cpp:137
> +    }, std::chrono::milliseconds(delay));

We should convert this to microseconds after r174818

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141017/41752d81/attachment-0002.html>