[Webkit-unassigned] [Bug 137586] import-w3c-test rewrites relative src paths in ref files incorrectly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137586





--- Comment #5 from Rebecca Hauck <rhauck at adobe.com>  2014-10-15 14:00:54 PST ---
(From update of attachment 239821)
View in context: https://bugs.webkit.org/attachment.cgi?id=239821&action=review

>> Tools/Scripts/webkitpy/w3c/test_converter.py:170
>> +            for attr in attrs:
> 
> Why the switch here? It seems much more readable to use atter_name and attr_value instead of attr[0] and attr[1].

I mentioned this in my previous patch. I changed this to be more consistent with the other blocks in this function.  If you think attr_name/value are better, I can change the other blocks in this function so they are all consistent.  what do you think?

>> Tools/Scripts/webkitpy/w3c/test_converter.py:171
>>                  if attr_name == 'src':
> 
> attr_name isn't defined.

oops, missed that. I'll fix in next patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.