[Webkit-unassigned] [Bug 137586] import-w3c-test rewrites relative src paths in ref files incorrectly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137586


Bem Jones-Bey <bjonesbe at adobe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239821|review?                     |review-
               Flag|                            |




--- Comment #4 from Bem Jones-Bey <bjonesbe at adobe.com>  2014-10-14 13:59:41 PST ---
(From update of attachment 239821)
View in context: https://bugs.webkit.org/attachment.cgi?id=239821&action=review

You need to rebase the patch, it no longer applies. Also, see below.

> Tools/Scripts/webkitpy/w3c/test_converter.py:170
> -            for attr_name, attr_value in attrs:
> +            for attr in attrs:

Why the switch here? It seems much more readable to use atter_name and attr_value instead of attr[0] and attr[1].

> Tools/Scripts/webkitpy/w3c/test_converter.py:171
>                  if attr_name == 'src':

attr_name isn't defined.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.