[Webkit-unassigned] [Bug 137553] abandoned select option is reselected when shift selecting new options

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137553





--- Comment #11 from Pascal Jacquemart <p.jacquemart at samsung.com>  2014-10-15 06:08:59 PST ---
(From update of attachment 239868)
View in context: https://bugs.webkit.org/attachment.cgi?id=239868&action=review

> Source/WebCore/html/HTMLSelectElement.cpp:880
>  

Deselect should be called first, otherwise the active selection wrongly records previously selected states

> Source/WebCore/html/HTMLSelectElement.cpp:884
> +    if (is<HTMLOptionElement>(element)) {

At this stage "element" could be null (if listIndex was -1)
It takes benefit of recent change from Chris Dumez: is<>(T*) is now doing a null check on the pointer argument

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.