[Webkit-unassigned] [Bug 137541] Errors using git-add-reviewer on a branch whose name includes parentheses

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137541





--- Comment #6 from Dana Burkart <dburkart at apple.com>  2014-10-09 09:36:56 PST ---
(In reply to comment #5)
> (From update of attachment 239500 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239500&action=review
> 
> > Tools/Scripts/git-add-reviewer:311
> > +    chomp(my $mergeBase = `git merge-base '$ancestor' '$descendant'`);
> 
> This relies on the names not having single quote in them. Is that guaranteed?

For $ancestor, it should be guaranteed, however, for $descendant it isn't... apparently, git allows quotes in branch names

> 
> > Tools/Scripts/git-add-reviewer:319
> > +    chomp(my $commit = `git rev-parse '$arg'`);
> 
> This relies on the argument not having a single quote in it. Is that guaranteed?

Not guaranteed for $arg either. 

An alternative solution could be to replace the backticks with a call to perl's system(), which won't invoke sh and should side-step the parenthesis problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.