[Webkit-unassigned] [Bug 137541] Errors using git-add-reviewer on a branch whose name includes parentheses

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137541


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239500|review?                     |review+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2014-10-09 09:28:09 PST ---
(From update of attachment 239500)
View in context: https://bugs.webkit.org/attachment.cgi?id=239500&action=review

> Tools/Scripts/git-add-reviewer:311
> +    chomp(my $mergeBase = `git merge-base '$ancestor' '$descendant'`);

This relies on the names not having single quote in them. Is that guaranteed?

> Tools/Scripts/git-add-reviewer:319
> +    chomp(my $commit = `git rev-parse '$arg'`);

This relies on the argument not having a single quote in it. Is that guaranteed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.