[Webkit-unassigned] [Bug 136692] [GTK] Race condition with WebKitWebView:is-loading after starting page load

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136692





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-10-08 22:42:12 PST ---
(In reply to comment #6)
> (From update of attachment 238303 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238303&action=review
> 
> LGTM, thanks!
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1590
> > +    if (isDelayedEvent) {
> > +        if (loadEvent == WEBKIT_LOAD_COMMITTED)
> > +            webView->priv->waitingForMainResource = false;
> > +        else if (loadEvent == WEBKIT_LOAD_FINISHED) {
> > +            // Manually set is-loading again in case a new load was started.
> > +            webkitWebViewSetIsLoading(webView, getPage(webView)->pageLoadState().isLoading());
> > +        }
> > +    }
> 
> Is there a reason not to do these checks in the if/else if block above? Do they need to come after the load changed signal emission?

Exactly, for example we guarantee that is-loading is false when load-changed is emitted with FINISHED.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.