[Webkit-unassigned] [Bug 136692] [GTK] Race condition with WebKitWebView:is-loading after starting page load
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 8 11:29:22 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=136692
Gustavo Noronha (kov) <gns at gnome.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #238303|review? |review+
Flag| |
--- Comment #6 from Gustavo Noronha (kov) <gns at gnome.org> 2014-10-08 11:29:18 PST ---
(From update of attachment 238303)
View in context: https://bugs.webkit.org/attachment.cgi?id=238303&action=review
LGTM, thanks!
> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1590
> + if (isDelayedEvent) {
> + if (loadEvent == WEBKIT_LOAD_COMMITTED)
> + webView->priv->waitingForMainResource = false;
> + else if (loadEvent == WEBKIT_LOAD_FINISHED) {
> + // Manually set is-loading again in case a new load was started.
> + webkitWebViewSetIsLoading(webView, getPage(webView)->pageLoadState().isLoading());
> + }
> + }
Is there a reason not to do these checks in the if/else if block above? Do they need to come after the load changed signal emission?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list