[Webkit-unassigned] [Bug 136819] Move DragController::createFragmentFromDragData implementation to the editor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136819





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-10-03 09:18:44 PST ---
(In reply to comment #6)
> (From update of attachment 238243 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238243&action=review
> 
> A good step in the right direction. I suspect we can keep refactoring this to make the code even tighter over time.

Thanks for the review.

> > Source/WebCore/editing/win/EditorWin.cpp:51
> > +template <typename PlatformDragData>
> > +static PassRefPtr<DocumentFragment> createFragmentFromPlatformData(PlatformDragData* platformDragData, Frame& frame)
> 
> Should take PlatformDragData& instead of PlatformDragData*.

Sure.

> I’m also surprised this needs to be a template. Are all four functions called here really overloaded for two different types!?

Yes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.