[Webkit-unassigned] [Bug 136819] Move DragController::createFragmentFromDragData implementation to the editor

Fri Oct 3 09:05:49 PDT 2014

https://bugs.webkit.org/show_bug.cgi?id=136819

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #238243|review?                     |review+
               Flag|                            |

--- Comment #6 from Darin Adler <darin at apple.com>  2014-10-03 09:05:46 PST ---
(From update of attachment 238243)
View in context: https://bugs.webkit.org/attachment.cgi?id=238243&action=review

A good step in the right direction. I suspect we can keep refactoring this to make the code even tighter over time.

> Source/WebCore/editing/win/EditorWin.cpp:51
> +template <typename PlatformDragData>
> +static PassRefPtr<DocumentFragment> createFragmentFromPlatformData(PlatformDragData* platformDragData, Frame& frame)

Should take PlatformDragData& instead of PlatformDragData*.

I’m also surprised this needs to be a template. Are all four functions called here really overloaded for two different types!?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.