[Webkit-unassigned] [Bug 137303] commitqueuetasks_unittest references a non-existent member variable when mock-reporting flakey tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137303





--- Comment #3 from Jake Nielsen <jake.nielsen.webkit at gmail.com>  2014-10-01 13:19:21 PST ---
(In reply to comment #2)
> (From update of attachment 239033 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239033&action=review
> 
> > Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:80
> >      def report_flaky_tests(self, patch, flaky_results, results_archive):
> > -        flaky_tests = [result.filename for result in flaky_results]
> > +        flaky_tests = [result.test_name for result in flaky_results]
> >          _log.info("report_flaky_tests: patch='%s' flaky_tests='%s' archive='%s'" % (patch.id(), flaky_tests, results_archive.filename))
> 
> How did you come to the decision to fix this code as opposed to removing it? I mean, you mentioned in comment #0 that this is "unexcercised [sic] code". We should not keep unused code in the tree.

I found this bug because one of the changes I was going to make exercised this code. Although it's not exercised as of this moment, it likely will be in the near future. Probably by me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.