[Webkit-unassigned] [Bug 137303] commitqueuetasks_unittest references a non-existent member variable when mock-reporting flakey tests.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 1 12:51:26 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=137303
Daniel Bates <dbates at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #239033|review?, commit-queue? |review-, commit-queue-
Flag| |
--- Comment #2 from Daniel Bates <dbates at webkit.org> 2014-10-01 12:51:25 PST ---
(From update of attachment 239033)
View in context: https://bugs.webkit.org/attachment.cgi?id=239033&action=review
> Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:80
> def report_flaky_tests(self, patch, flaky_results, results_archive):
> - flaky_tests = [result.filename for result in flaky_results]
> + flaky_tests = [result.test_name for result in flaky_results]
> _log.info("report_flaky_tests: patch='%s' flaky_tests='%s' archive='%s'" % (patch.id(), flaky_tests, results_archive.filename))
How did you come to the decision to fix this code as opposed to removing it? I mean, you mentioned in comment #0 that this is "unexcercised [sic] code". We should not keep unused code in the tree.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list