[Webkit-unassigned] [Bug 128177] [EFL] Switch to CUSTOM_PROTOCOLS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128177





--- Comment #5 from Anton Obzhirov <a.obzhirov at samsung.com>  2014-10-01 07:44:53 PST ---
(From update of attachment 238932)
View in context: https://bugs.webkit.org/attachment.cgi?id=238932&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_url_scheme_request.cpp:42
> +    WKURLRef url = toCopiedURLAPI(urlRequest->resourceRequest().url());

These 2 lines can be compressed in one and moved up - m_url(WKEinaSharedString(toCopiedURLAPI(urlRequest->resourceRequest().url())))

> Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.cpp:86
> +    RefPtr<WebKitURISchemeHandler> handler = adoptRef(new WebKitURISchemeHandler(callback, userData));

I think you shouldn't pass raw pointer here. The ref pointer goes out of scope in this function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.