[Webkit-unassigned] [Bug 128177] [EFL] Switch to CUSTOM_PROTOCOLS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128177





--- Comment #4 from Pascal Jacquemart <p.jacquemart at samsung.com>  2014-10-01 03:57:59 PST ---
(From update of attachment 238932)
View in context: https://bugs.webkit.org/attachment.cgi?id=238932&action=review

>> Source/cmake/OptionsEfl.cmake:311
>> +add_definitions(-DENABLE_CUSTOM_PROTOCOLS=1)
> 
> Please add CUSTOM_PROTOCOLS definitions to WebKitFeatures.cmake.

Are you sure?
In my understanding CUSTOM_PROTOCOLS is already the default on MAC and GTK
After this patch EFL won't compile without CUSTOM_PROTOCOLS
And as soon as EFL switch to CUSTOM_PROTOCOLS the flag itself will be removed from WebKit (as being the default for all ports)

>> Tools/MiniBrowser/efl/main.c:75
>> +static void about_url_scheme_request_cb(Ewk_Url_Scheme_Request *request, void *user_data)
> 
> *about* looks like a redundant prefix.

I think it is perfectly fine
- It's actually a copy paste from "ewk_context.h" (ewk_context_url_scheme_register() API documentation)
- This "about" indicates which new scheme we are implementing (the I guess each new scheme callback would have its own prefix)
- It is consistent with GTK aboutURISchemeRequestCallback() naming

> Tools/MiniBrowser/efl/main.c:81
> +    path = ewk_url_scheme_request_path_get(request);

Now I realize this ewk_url_scheme_request_path_get() is working fine
But the test scenario itself should be considered:
  Tools/Scripts/run-launcher --efl minibrowser-about:plugins
    -> callback not called because function has_scheme() checks for "://" in the url, otherwise assume "http" scheme
  Tools/Scripts/run-launcher --efl minibrowser-about://plugins
    -> callback is called but ewk_url_scheme_request_path_get() returns an empty string, which is the expected behaviour
  Tools/Scripts/run-launcher --efl minibrowser-about:///plugins
    -> callback is called, path is "///plugins", this is correct but the subsequent tests will fail ("///" start is unexpected)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.