[Webkit-unassigned] [Bug 139064] [GStreamer] HTTP source element lacks SCHEDULING query support
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 26 08:06:05 PST 2014
https://bugs.webkit.org/show_bug.cgi?id=139064
Carlos Garcia Campos <cgarcia at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #242229|review? |review+
Flags| |
--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 242229
--> https://bugs.webkit.org/attachment.cgi?id=242229
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=242229&action=review
> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:589
> + gint minSize, maxSize, align;
Nit: use int instead of gint here.
> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:592
> + flags = static_cast<GstSchedulingFlags>(static_cast<unsigned>(flags) | GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED);
Do you really need the unsigned cast too? can't this be flags |= GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141126/2d9ba765/attachment-0002.html>
More information about the webkit-unassigned
mailing list