[Webkit-unassigned] [Bug 139064] [GStreamer] HTTP source element lacks SCHEDULING query support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139064

--- Comment #3 from Philippe Normand <pnormand at igalia.com> ---
(In reply to comment #2)
> Comment on attachment 242229 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242229&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:589
> > +        gint minSize, maxSize, align;
> 
> Nit: use int instead of gint here.
> 

ok :)

> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:592
> > +        flags = static_cast<GstSchedulingFlags>(static_cast<unsigned>(flags) | GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED);
> 
> Do you really need the unsigned cast too? can't this be flags |=
> GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED?

Fails to build here:

../../Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In function ‘gboolean webKitWebSrcQueryWithParent(GstPad*, GstObject*, GstQuery*)’:
../../Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:593:15: error: invalid conversion from ‘int’ to ‘GstSchedulingFlags’ [-fpermissive]
         flags |= GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141126/b17f3dc7/attachment-0002.html>